Serosh-commits wrote:

> I'm not sure about this fix - could you please see what happens with the 
> other builtins going through `checkBuiltinTemplateIdType` to see if they 
> handle insufficient template parameters? Because they don't seem to be doing 
> checks for sufficient parameters before using them.
> 
> This might need to be a generic fix on how the builtin templates are checked

thanks for checking@ojhunt
you are right, the other builtins also assume exact size without extra checks  
but since they’re rarely used with dependent/insufficient args (except maybe 
__type_pack_element which is pack-focused), I went for the minimal fix to close 
this crash quickly
if you think a generic early check would be better i can add one at the top of 
the function just let me know what you prefer 

https://github.com/llvm/llvm-project/pull/180407
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to