mtrofin wrote:

> Tagging authors of modified tests: @ostannard (`fullfp-neon-*`) @MaskRay 
> (`data-segment-relro-ppc64.test`) @mtrofin (`autodetect-roots.cpp`) @OCHyams 
> (`KeyInstructions/flag.cpp`)
> 
> Just a note, regarding `autodetect-roots.cpp`, the binary compiled in the 
> test wasn't executed previously. Now it is, and it always runs for 10 seconds 
> (the main thread sleeps for 10s). I'm not sure if there are other tests that 
> run that long. It can be decreased, but might become flaky.

Nice fix!

I've seen other tests running for some amount of time, esp. in debug. Since 
tests run in parallel, I wouldn't worry about it (but let's see, of course)

https://github.com/llvm/llvm-project/pull/179668
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to