rturrado wrote:

> Is it false-negative instead of false positive? since it looks like miss to 
> diag something

Thanks for checking this.

I tried to mimick the `map.try_emplace(0, f)`, `f` of type 
`std::function<void()>`, with a test, but I hadn't checked against the original 
[program](https://godbolt.org/z/bjYqaP857) itself. I have tried now and I have 
seen 2 problems:

1. `map.try_emplace(0, f)` is indeed a false negative (it doesn't emit any 
warning).
2. `map.try_emplace(0, std::move(f)` is a false positive (it recommends to 
move).

https://github.com/llvm/llvm-project/pull/180806
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to