[clang] [clang][CFG] Sequence RHS before LHS for overloaded assignment operators in CFG to match C++17 rules (PR #181113)

[Utkarsh Saxena via cfe-commits]

================
@@ -2542,6 +2543,19 @@ CFGBlock *CFGBuilder::VisitChildren(Stmt *S) {
   return B;
 }
 
+CFGBlock *CFGBuilder::VisitCallExprChildren(CallExpr *C) {
+  // C++17 onwards require that the right operand is sequenced before the left
+  // operand.
+  if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(C)) {
----------------
usx95 wrote:

nit: combine in a single `if`

`  if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(C); OCE && 
OCE->isAssignmentOp())`

https://github.com/llvm/llvm-project/pull/181113
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits