================
@@ -399,55 +399,56 @@ class BranchNodeBuilder: public NodeBuilder {
ExplodedNode *Pred);
};
-class IndirectGotoNodeBuilder {
- const CoreEngine &Eng;
- const CFGBlock *Src;
+class IndirectGotoNodeBuilder : public NodeBuilder {
----------------
steakhal wrote:
So `NodeBuilder` is a polymorphic base.
That suggest to me that we should mark us `final` here to allow
devirtualizations to happen.
I think we should also add or override an `anchor` method as per
https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers
Same reasoning applies to the other derived classes.
https://github.com/llvm/llvm-project/pull/180960
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
