================
@@ -2369,13 +2393,15 @@ mlir::LogicalResult 
CIRToLLVMFuncOpLowering::matchAndRewrite(
          "expected single location or unknown location here");
 
   mlir::LLVM::Linkage linkage = convertLinkage(op.getLinkage());
-  assert(!cir::MissingFeatures::opFuncCallingConv());
-  mlir::LLVM::CConv cconv = mlir::LLVM::CConv::C;
+  auto cconv = convertCallingConv(op.getCallingConv());
----------------
Lancern wrote:

```suggestion
  std::optional<mlir::LLVM::CConv> cconv = 
convertCallingConv(op.getCallingConv());
```

https://github.com/llvm/llvm-project/pull/181170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to