================
@@ -525,6 +525,7 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {
     return createAlignedLoad(loc, ty, ptr, align.getAsAlign());
   }
 
+  using CIRBaseBuilderTy::createStore;
----------------
ayokunle321 wrote:

Since `CIRGenBuilder` is derived from `CIRBaseBuilderTy` and `CIRGenBuilder` 
has its own impl. of `createstore`, `CIRBaseBuilderTy`'s `createStore` is 
hidden. And I needed `CIRBaseBuilderTy`'s `createStore` because it's 
implementation could take in an `mlir::Value` as a destination address instead 
of a constructed `Address` with an alignment. 

If i used `CIRGenBuilder`'s `createStore` then I would have had to construct 
`castBuf` as an `Address` with an alignment but `castBuf` does not need to be 
aligned.

And so I brought `CIRBaseBuilderTy`'s `createStore` to this scope.

https://github.com/llvm/llvm-project/pull/178989
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to