evelez7 wrote: > I was thinking of 2), that defaults to 3) for long function names. Long > function names could push the parameters too much to the right, and its > better to implement 3) for them. <img alt="image" width="1432" height="237" > src="https://private-user-images.githubusercontent.com/74651507/549884596-8448ba2b-a134-4234-8094-4e4ecdd0bdb8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzExODY3NDksIm5iZiI6MTc3MTE4NjQ0OSwicGF0aCI6Ii83NDY1MTUwNy81NDk4ODQ1OTYtODQ0OGJhMmItYTEzNC00MjM0LTgwOTQtNGU0ZWNkZDBiZGI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE1VDIwMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhMDI1ZWNkMWZiZmMwY2M4MDI4NTRlNGUwNWM2ZDA2ODVkMDY5YzU0YWM5ZmIzNjg5M2IyNjVmNTg2YzYyNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.q1KzSEBsg7rt-QNSHYwqlt04D-wgSy5siQSjFS515IU";>
I think I agree with this at a glance. I prefer option 2 but defaulting to 3 if needed is OK. Curious about other thoughts on this design. Once this is discussed a bit more and the problems with CI are fixed, I can throw this up on my static URL for a good look. https://github.com/llvm/llvm-project/pull/181417 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
![https://private-user-images.githubusercontent.com/74651507/549884596-8448ba2b-a134-4234-8094-4e4ecdd0bdb8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzExODY3NDksIm5iZiI6MTc3MTE4NjQ0OSwicGF0aCI6Ii83NDY1MTUwNy81NDk4ODQ1OTYtODQ0OGJhMmItYTEzNC00MjM0LTgwOTQtNGU0ZWNkZDBiZGI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE1VDIwMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhMDI1ZWNkMWZiZmMwY2M4MDI4NTRlNGUwNWM2ZDA2ODVkMDY5YzU0YWM5ZmIzNjg5M2IyNjVmNTg2YzYyNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.q1KzSEBsg7rt-QNSHYwqlt04D-wgSy5siQSjFS515IU"](https://private-user-images.githubusercontent.com/74651507/549884596-8448ba2b-a134-4234-8094-4e4ecdd0bdb8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzExODY3NDksIm5iZiI6MTc3MTE4NjQ0OSwicGF0aCI6Ii83NDY1MTUwNy81NDk4ODQ1OTYtODQ0OGJhMmItYTEzNC00MjM0LTgwOTQtNGU0ZWNkZDBiZGI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjE1VDIwMTQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhMDI1ZWNkMWZiZmMwY2M4MDI4NTRlNGUwNWM2ZDA2ODVkMDY5YzU0YWM5ZmIzNjg5M2IyNjVmNTg2YzYyNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.q1KzSEBsg7rt-QNSHYwqlt04D-wgSy5siQSjFS515IU"){kind=link}