https://github.com/zmodem approved this pull request.

> Instead of checking the SuppressSystemWarnings bit of the current DiagState, 
> I introduced a new `ForceSystemWarnings` flag in DiagnosticsEngine that lives 
> outside of the DiagState mechanism.

Thanks! I think this is a good fix.

LGTM modulo some comment nits.

https://github.com/llvm/llvm-project/pull/180684
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to