github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp --
clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
clang/lib/Analysis/LifetimeSafety/Checker.cpp
clang/lib/Analysis/LifetimeSafety/Facts.cpp
clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
clang/lib/Analysis/LifetimeSafety/LiveOrigins.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
index f797e93fd..17aa033ab 100644
--- a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
+++ b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
@@ -152,7 +152,7 @@ public:
enum class EscapeKind : uint8_t {
Return, /// Escapes via return statement.
Field, /// Escapes via assignment to a field.
- Global, /// Escapes via assignment to global storage.
+ Global, /// Escapes via assignment to global storage.
} EscKind;
static bool classof(const Fact *F) {
@@ -208,7 +208,7 @@ class GlobalEscapeFact : public OriginEscapesFact {
public:
GlobalEscapeFact(OriginID OID, const VarDecl *VDecl)
- : OriginEscapesFact(OID, EscapeKind::Global), VDecl(VDecl) {}
+ : OriginEscapesFact(OID, EscapeKind::Global), VDecl(VDecl) {}
static bool classof(const Fact *F) {
return F->getKind() == Kind::OriginEscapes &&
diff --git
a/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
b/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
index 20b89d5e1..8b464902f 100644
--- a/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
+++ b/clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h
@@ -95,7 +95,7 @@ public:
// Reports misuse of [[clang::noescape]] when parameter escapes through field
virtual void reportNoescapeViolation(const ParmVarDecl *ParmWithNoescape,
const FieldDecl *EscapeField) {}
- // Reports misuse of [[clang::noescape]] when parameter escapes through
+ // Reports misuse of [[clang::noescape]] when parameter escapes through
// assignment to a global variable
virtual void reportNoescapeViolation(const ParmVarDecl *ParmWithNoescape,
const ValueDecl *EscapeGlobal) {}
diff --git a/clang/lib/Analysis/LifetimeSafety/Facts.cpp
b/clang/lib/Analysis/LifetimeSafety/Facts.cpp
index fca103108..4ffc8b419 100644
--- a/clang/lib/Analysis/LifetimeSafety/Facts.cpp
+++ b/clang/lib/Analysis/LifetimeSafety/Facts.cpp
@@ -70,7 +70,7 @@ void FieldEscapeFact::dump(llvm::raw_ostream &OS, const
LoanManager &,
}
void GlobalEscapeFact::dump(llvm::raw_ostream &OS, const LoanManager &,
- const OriginManager &OM) const {
+ const OriginManager &OM) const {
OS << "OriginEscapes (";
OM.dump(getEscapedOriginID(), OS);
OS << ", via Global)\n";
diff --git a/clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
b/clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
index 6b0b1a10a..4d570a449 100644
--- a/clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
+++ b/clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
@@ -371,10 +371,10 @@ void FactsGenerator::handleAssignment(const Expr *LHSExpr,
if (GlobalLHS) {
for (OriginList *L = RHSList; L != nullptr; L = L->peelOuterOrigin()) {
EscapesInCurrentBlock.push_back(FactMgr.createFact<GlobalEscapeFact>(
- L->getOuterOriginID(), GlobalLHS));
+ L->getOuterOriginID(), GlobalLHS));
}
};
-
+
if (const auto *DRE_LHS = dyn_cast<DeclRefExpr>(LHSExpr))
markUseAsWrite(DRE_LHS);
// Kill the old loans of the destination origin and flow the new loans
``````````
</details>
https://github.com/llvm/llvm-project/pull/181646
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits