rapidsna wrote: > It's great to see the AST -> Sema dependency removed. > > I'm still concerned about the move of LateParsedDeclaration and > LateParsedAttribute from Parser to Sema. Those classes seem very parsing > specific. > > And scrolling down, I see that their implementations are still in Parser. > That doesn't seem right -- I don't think we can define LateParsedDeclaration > in Sema/DeclSpec.h and implement it in Parse/ParseCXXInlineMethods.cpp. > > Maybe the parsing and the sema parts can be split apart somehow. How do the > parser and sema collaborate around regular ParsedAttr objects?
`ParsedAttr` is defined in `ParsedAttr.h` and it's included in `Sema.h` and `Parser.h` includes `Sema.h`, so both Sema and Parser see the definition of `ParsedAttr`. https://github.com/llvm/llvm-project/pull/179612 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
