https://github.com/jansvoboda11 commented:
Does the incremental scan benchmark actually relocate any modules? Can you give absolute numbers of your benchmarks? In the past, I mostly optimized for the clean scan case, because that's fairly slow, while the incremental scan is typically much faster. If that's still the case, I think the 4.7% regression in the incremental case is fine. The intent here seems reasonable, I have just a couple of minor comments. https://github.com/llvm/llvm-project/pull/181836 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
