https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/117644
>From ac8ddaf7055145ef29e260adc8c079fa372d5a1c Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Mon, 25 Nov 2024 15:26:44 -0800 Subject: [PATCH 1/4] tools: Remove unused PluginLoader includes As far as I can tell there are 2 parallel plugin mechanisms. opt -load=plugin does not work, and is ignored. opt -load-pass-plugin does work. The only user of PluginLoader appears to be bugpoint. --- clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp | 3 +-- lld/tools/lld/lld.cpp | 1 - llvm/tools/llc/llc.cpp | 1 - llvm/tools/lli/lli.cpp | 1 - llvm/tools/llvm-lto2/llvm-lto2.cpp | 1 - llvm/tools/opt/optdriver.cpp | 1 - 6 files changed, 1 insertion(+), 7 deletions(-) diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp index 2b2e53dc0be19..12ef30f0dfb7f 100644 --- a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp +++ b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp @@ -23,7 +23,6 @@ #include "llvm/ADT/StringSet.h" #include "llvm/Support/CommandLine.h" #include "llvm/Support/InitLLVM.h" -#include "llvm/Support/PluginLoader.h" // IWYU pragma: keep #include "llvm/Support/Process.h" #include "llvm/Support/Signals.h" #include "llvm/Support/TargetSelect.h" @@ -364,7 +363,7 @@ line sent to the compiler. Please note that removing arguments might change the semantic of the analyzed code, possibly leading to compiler errors, false positives or -false negatives. This option is applied +false negatives. This option is applied before --extra-arg and --extra-arg-before)"), cl::cat(ClangTidyCategory)); diff --git a/lld/tools/lld/lld.cpp b/lld/tools/lld/lld.cpp index d6800fa1eea4b..3aaed7e83104f 100644 --- a/lld/tools/lld/lld.cpp +++ b/lld/tools/lld/lld.cpp @@ -35,7 +35,6 @@ #include "llvm/Support/CrashRecoveryContext.h" #include "llvm/Support/LLVMDriver.h" #include "llvm/Support/Path.h" -#include "llvm/Support/PluginLoader.h" #include "llvm/Support/Process.h" #include "llvm/TargetParser/Host.h" #include "llvm/TargetParser/Triple.h" diff --git a/llvm/tools/llc/llc.cpp b/llvm/tools/llc/llc.cpp index 34ce2bc0622a6..3174ed5a33bab 100644 --- a/llvm/tools/llc/llc.cpp +++ b/llvm/tools/llc/llc.cpp @@ -49,7 +49,6 @@ #include "llvm/Support/InitLLVM.h" #include "llvm/Support/PGOOptions.h" #include "llvm/Support/Path.h" -#include "llvm/Support/PluginLoader.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/TargetSelect.h" #include "llvm/Support/TimeProfiler.h" diff --git a/llvm/tools/lli/lli.cpp b/llvm/tools/lli/lli.cpp index 9bae77cc10335..dd00d080385b6 100644 --- a/llvm/tools/lli/lli.cpp +++ b/llvm/tools/lli/lli.cpp @@ -60,7 +60,6 @@ #include "llvm/Support/Memory.h" #include "llvm/Support/MemoryBuffer.h" #include "llvm/Support/Path.h" -#include "llvm/Support/PluginLoader.h" #include "llvm/Support/Process.h" #include "llvm/Support/Program.h" #include "llvm/Support/SourceMgr.h" diff --git a/llvm/tools/llvm-lto2/llvm-lto2.cpp b/llvm/tools/llvm-lto2/llvm-lto2.cpp index 955c1130e9f4c..6c661ed8491b0 100644 --- a/llvm/tools/llvm-lto2/llvm-lto2.cpp +++ b/llvm/tools/llvm-lto2/llvm-lto2.cpp @@ -26,7 +26,6 @@ #include "llvm/Support/CommandLine.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/InitLLVM.h" -#include "llvm/Support/PluginLoader.h" #include "llvm/Support/TargetSelect.h" #include "llvm/Support/Threading.h" #include "llvm/Support/TimeProfiler.h" diff --git a/llvm/tools/opt/optdriver.cpp b/llvm/tools/opt/optdriver.cpp index adfbf2e368e58..8af7eb617fc90 100644 --- a/llvm/tools/opt/optdriver.cpp +++ b/llvm/tools/opt/optdriver.cpp @@ -45,7 +45,6 @@ #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/InitLLVM.h" -#include "llvm/Support/PluginLoader.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/SystemUtils.h" #include "llvm/Support/TargetSelect.h" >From 7f0908c2e1e0199e4c1fdd6ac56d934a866a30bd Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Tue, 26 Nov 2024 12:52:35 -0500 Subject: [PATCH 2/4] Revert failing test cases --- clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp | 1 + lld/tools/lld/lld.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp index 12ef30f0dfb7f..123d6c23427b8 100644 --- a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp +++ b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp @@ -23,6 +23,7 @@ #include "llvm/ADT/StringSet.h" #include "llvm/Support/CommandLine.h" #include "llvm/Support/InitLLVM.h" +#include "llvm/Support/PluginLoader.h" #include "llvm/Support/Process.h" #include "llvm/Support/Signals.h" #include "llvm/Support/TargetSelect.h" diff --git a/lld/tools/lld/lld.cpp b/lld/tools/lld/lld.cpp index 3aaed7e83104f..d6800fa1eea4b 100644 --- a/lld/tools/lld/lld.cpp +++ b/lld/tools/lld/lld.cpp @@ -35,6 +35,7 @@ #include "llvm/Support/CrashRecoveryContext.h" #include "llvm/Support/LLVMDriver.h" #include "llvm/Support/Path.h" +#include "llvm/Support/PluginLoader.h" #include "llvm/Support/Process.h" #include "llvm/TargetParser/Host.h" #include "llvm/TargetParser/Triple.h" >From c2d98013d2242a49c046ee53f2f87a86cb54e273 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Tue, 4 Mar 2025 16:08:41 +0700 Subject: [PATCH 3/4] Revert opt case --- llvm/tools/opt/optdriver.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/llvm/tools/opt/optdriver.cpp b/llvm/tools/opt/optdriver.cpp index 8af7eb617fc90..adfbf2e368e58 100644 --- a/llvm/tools/opt/optdriver.cpp +++ b/llvm/tools/opt/optdriver.cpp @@ -45,6 +45,7 @@ #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/InitLLVM.h" +#include "llvm/Support/PluginLoader.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/SystemUtils.h" #include "llvm/Support/TargetSelect.h" >From f0066457f6366baceae04a839bceb0fc5faacab8 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Fri, 7 Mar 2025 12:22:42 +0700 Subject: [PATCH 4/4] Revert llvm-lto2 case --- llvm/tools/llvm-lto2/llvm-lto2.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/llvm/tools/llvm-lto2/llvm-lto2.cpp b/llvm/tools/llvm-lto2/llvm-lto2.cpp index 6c661ed8491b0..955c1130e9f4c 100644 --- a/llvm/tools/llvm-lto2/llvm-lto2.cpp +++ b/llvm/tools/llvm-lto2/llvm-lto2.cpp @@ -26,6 +26,7 @@ #include "llvm/Support/CommandLine.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/InitLLVM.h" +#include "llvm/Support/PluginLoader.h" #include "llvm/Support/TargetSelect.h" #include "llvm/Support/Threading.h" #include "llvm/Support/TimeProfiler.h" _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
