Author: Timm Baeder Date: 2026-02-22T09:27:11+01:00 New Revision: be2588ae02f2348c8932311a11ffb512e20009fc
URL: https://github.com/llvm/llvm-project/commit/be2588ae02f2348c8932311a11ffb512e20009fc DIFF: https://github.com/llvm/llvm-project/commit/be2588ae02f2348c8932311a11ffb512e20009fc.diff LOG: [clang][ExprConst] Remove bogus diagnostic (#181792) This diagnostic is untested and this code path should be dead. Added: Modified: clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/ExprConstant.cpp Removed: ################################################################################ diff --git a/clang/include/clang/Basic/DiagnosticASTKinds.td b/clang/include/clang/Basic/DiagnosticASTKinds.td index 5446c0d89597b..1afae9b1fc1a2 100644 --- a/clang/include/clang/Basic/DiagnosticASTKinds.td +++ b/clang/include/clang/Basic/DiagnosticASTKinds.td @@ -427,12 +427,6 @@ def note_constexpr_unscoped_enum_out_of_range : Note< "integer value %0 is outside the valid range of values [%1, %2] for the " "enumeration type %3">; -// This is a temporary diagnostic, and shall be removed once our -// implementation is complete, and like the preceding constexpr notes belongs -// in Sema. -def note_unimplemented_constexpr_lambda_feature_ast : Note< - "unimplemented constexpr lambda feature: %0 (coming soon!)">; - def warn_is_constant_evaluated_always_true_constexpr : Warning< "'%0' will always evaluate to 'true' in a manifestly constant-evaluated expression">, InGroup<DiagGroup<"constant-evaluated">>; diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index b06233423db4d..3ddf8903378bf 100644 --- a/clang/lib/AST/ExprConstant.cpp +++ b/clang/lib/AST/ExprConstant.cpp @@ -3373,12 +3373,9 @@ static bool evaluateVarDeclInit(EvalInfo &Info, const Expr *E, "missing value for local variable"); if (Info.checkingPotentialConstantExpression()) return false; - // FIXME: This diagnostic is bogus; we do support captures. Is this code - // still reachable at all? - Info.FFDiag(E->getBeginLoc(), - diag::note_unimplemented_constexpr_lambda_feature_ast) - << "captures not currently allowed"; - return false; + + llvm_unreachable( + "A variable in a frame should either be a local or a parameter"); } } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
