https://github.com/steakhal approved this pull request.
I'm going to be honest with you. I have no idea how it traverses things, so I have no way of checking if that part is correct. I'll just rubber-stamp this. What is sure, that the moved diagnostic location looks a lot more sensible to me. This aligned with one of my earlier comments when this whole annotate started, and I raised that in the future the violation location can get unpredictably far away from the function declaration. So here we are. https://github.com/llvm/llvm-project/pull/182614 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
