================ ---------------- tarunprabhu wrote:
As this comment says, the Integration directory should be used sparingly. I looked through the code again, and I think checking the lowering to an MLIR attribute is sufficient in this case. The lowering of MLIR attribute to LLVM-IR is tested elsewhere, so as long as we generate the value of the attribute correctly, we can be certain that the end-to-end behavior will be correct. See, for example, `flang/test/Lowering/record-command-line.f90`. Without a test for lowering to MLIR, this would be the only way check that lowering. The major disadvantage of this approach is that it requires the X86 target to be available. Anyone building with, say, -DLLVM_TARGETS_TO_BUILD=host on aarch64 would unnecessarily lose some test coverage. https://github.com/llvm/llvm-project/pull/181686 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
