https://github.com/jhuber6 approved this pull request.
Since we're only doing this to variables referenced on the host side directly rather than changing standard symbols I think this is fine. `extern const` would still need to be used if someone was using this from an RDC context, but that's reasonable. LG once rebased so we don't put `externally initialized` on these constants anymore. `externally initialized` also serves as a barrier to internalization / GlobalOpt but because these are externalized they should also not be legal to remove. https://github.com/llvm/llvm-project/pull/177292 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
