kikairoya wrote:

> how about we drop (ignore) the dllimport/export attribute in that case (with 
> a warning)?

Done.
That change consists of two steps: make the exclude attribute ignored on a 
non-template context, and make the exclude attribute takes precedence over the 
DLL attributes.
If this approach makes sense, I'll submit them as separated PRs.

>> Would doing -DAG checks help?
>
> That doesn't work because --implicit-check-not seems to be ignored around 
> -DAG checks.

Switched to use `-DAG` checks by extracting the negative checks to another 
`FileCheck` path.

> No, we can't. Clang doesn't export/import inline methods in MinGW mode.

That was inaccurate. A method of a class template will be exported/imported 
regardless of inline.



https://github.com/llvm/llvm-project/pull/168171
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to