https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/183548
>From 78bc1a3d488ce21f0d37ec397c0eddbbfd8345bc Mon Sep 17 00:00:00 2001 From: Joseph Huber <[email protected]> Date: Thu, 26 Feb 2026 09:10:36 -0600 Subject: [PATCH 1/2] [Clang] Enable response file support for 'llvm-offload-binary' Summary: These command line invocations can become so large that they no longer fit, we should support response files in this case so the build on Windows can be unblocked with the new driver. --- clang/lib/Driver/ToolChains/Clang.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 79005d97b41ee..1b73fde5f5c25 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -9240,7 +9240,7 @@ void OffloadPackager::ConstructJob(Compilation &C, const JobAction &JA, } C.addCommand(std::make_unique<Command>( - JA, *this, ResponseFileSupport::None(), + JA, *this, ResponseFileSupport::AtFileUTF8(), Args.MakeArgString(getToolChain().GetProgramPath(getShortName())), CmdArgs, Inputs, Output)); } >From 1ba3251fdbd70c9b83b51c5ab2b90dc129f85ed5 Mon Sep 17 00:00:00 2001 From: Joseph Huber <[email protected]> Date: Thu, 26 Feb 2026 09:31:18 -0600 Subject: [PATCH 2/2] test --- llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll | 3 +++ 1 file changed, 3 insertions(+) diff --git a/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll b/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll index c6027b360e5cc..5961b231da522 100644 --- a/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll +++ b/llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll @@ -1,6 +1,9 @@ ; RUN: llvm-offload-binary -o %t --image=file=%s,arch=abc,triple=x-y-z ; RUN: llvm-objdump --offloading %t | FileCheck %s ; RUN: llvm-offload-binary %t --image=file=%t2,arch=abc,triple=x-y-z +; RUN: echo "-o %t --image=file=%S/llvm-offload-binary.ll,arch=abc,triple=x-y-z" > %t.rsp +; RUN: llvm-offload-binary @%t.rsp +; RUN: llvm-objdump --offloading %t | FileCheck %s ; RUN: diff %s %t2 ; CHECK: OFFLOADING IMAGE [0]: _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
