https://github.com/AaronBallman commented:
The changes should come with tests for the new attribute spelling as well as a release note. Is this change something that's happening in the Swift compiler? Otherwise, I'm not certain this is the right direction. From our docs: > The ``swift_attr`` provides a Swift-specific annotation for the declaration or type to which the attribute appertains to. It can be used on any declaration or type in Clang. This kind of annotation is ignored by Clang as it doesn't have any semantic meaning in languages supported by Clang. The Swift compiler can interpret these annotations according to its own rules when importing C or Objective-C declarations. So if the Swift compiler doesn't support those spellings, it will be accepted by Clang (and do nothing) but be rejected by Swift. CC @compnerd @hyp @rjmccall for additional opinions (side note: maybe we should have an official point-of-contact for Swift questions?). https://github.com/llvm/llvm-project/pull/183484 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
