erichkeane wrote: > > # 🪟 Windows x64 Test Results > > ``` > > * 52791 tests passed > > > > * 983 tests skipped > > > > * 3 tests failed > > ``` > > > > > > > > > > > > > > > > > > > > > > > > ## Failed Tests > > (click on a test name to see its output) > > ### Clang > > Clang.AST/ast-dump-decl-json.m > > Clang.AST/ast-dump-decl.m > > Clang.SemaCXX/ms-property.cpp > > If these failures are unrelated to your changes (for example tests are > > broken or flaky at HEAD), please open an issue at > > https://github.com/llvm/llvm-project/issues and add the `infrastructure` > > label. > > looks like we forget about the ast printers json and text dumps they do need > parentheses so i think we have to add the IgnoreParens() locally as it was > before should we ?
Yes, that is fine. I still approve of the previous version as well given the new info. https://github.com/llvm/llvm-project/pull/183633 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
