Serosh-commits wrote:
> Thanks, you can remove all the changes except the very last one related to > the production of `err_template_expansion_into_fixed_list`. > > The technical reason why we put this "no pack expansion into fixed lists" > restriction on type alias templates is because the language spec mandates it, > but that spec was created because it's complicated to implement and means we > would need to support canonical type alias template specializations, and they > would start appearing in mangling. > > For builtin templates, we don't have the spec mandate, and we already produce > canonical specializations for them, and so they already appear in mangling, > but would still be a bit complicated to implement, and diagnosing them is > obviously better than just crashing, unless someone would want to volunteer > the effort to implement it. thanks for ur suggestions and time just to confirm a bit the only change you want kept is adding BuiltinTemplateDecl to the isa<> check in CheckTemplateArgumentList? and we don't need to add assert? https://github.com/llvm/llvm-project/pull/180407 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
