https://github.com/ojhunt approved this pull request.

Looks good, the only really comment is to consider adding an earlier assertion 
for correct state in MakeTrivial so the badness is caught when it's constructed 
incorrectly rather than during diags, but this is a relatively soft request so 
I won't block the fix on it :D

https://github.com/llvm/llvm-project/pull/183937
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to