Serosh-commits wrote:

> > @mizvekov i would be happy:) to volunteer anywhere regarding implementing 
> > that support for builtin templates , i wouldlove to contribute feel free to 
> > point me anywhere :)
> 
> Well, maybe you can wait for someone to ask for that feature, if you don't 
> have a need for it yourself.
> 
> Otherwise, the way to go would start reverting the new diagnostic in this 
> patch.
> 
> Probably for the simplest solution you could make CheckTemplateArgumentList 
> produce a result indicating there was a pack expansion into a fixed parameter 
> for the builtin template, and then use that to keep the template 
> specialization dependent.



> > @mizvekov i would be happy:) to volunteer anywhere regarding implementing 
> > that support for builtin templates , i wouldlove to contribute feel free to 
> > point me anywhere :)
> 
> Well, maybe you can wait for someone to ask for that feature, if you don't 
> have a need for it yourself.
> 
> Otherwise, the way to go would start reverting the new diagnostic in this 
> patch.
> 
> Probably for the simplest solution you could make CheckTemplateArgumentList 
> produce a result indicating there was a pack expansion into a fixed parameter 
> for the builtin template, and then use that to keep the template 
> specialization dependent.

may be we can make CheckTemplateArgumentList to return having three state 
result (success, incomplete pack, hard error) rather than just a bool would let 
checkBuiltinTemplateIdType detect the unexpanded pack case and return a 
dependent QualType instead of diagnosing but maybe that feels lazy evaluation :(

https://github.com/llvm/llvm-project/pull/180407
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to