NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
LGTM! I guess later it'd be great to comment on every `numTimesReached()` why is it supposed to be reached exactly that many times, as it's often unclear, especially with tricky control flow. Because if somebody accidentally breaks the test, they'd have no idea what it tests or why it should work this way. https://reviews.llvm.org/D36962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
