arphaman added inline comments.

================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:658
+  SourceRange Range;
+  if (auto *Arg = N.ASTNode.get<TemplateArgument>())
+    Range = TemplateArgumentLocations.at(&N - &Nodes[0]);
----------------
You can drop the `auto *Arg` since Arg is unused.


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:1305
 
+struct Patcher {
+  SyntaxTree::Impl &ModelSrc, &ModelDst, &Target;
----------------
Please move the patcher into a new file.


https://reviews.llvm.org/D37005



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to