NoQ added a comment.

Thank you for the review!

> Though it looks like some of the cases covered in the code do not have 
> corresponding tests (e.g.: the parenexprs).

These are covered by tests in `inline-defensive-checks.c:150,156,169,179` (old 
code had `IgnoreParenCasts`). This function is actually used a lot (even more 
so since https://reviews.llvm.org/D32291), and seems fairly well-tested, so i 
felt relatively safe when refactoring it.

> But I wonder if there could be some cases where we have such cast earlier 
> than expected.

I'd love to know :o


https://reviews.llvm.org/D37023



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to