https://github.com/erichkeane commented:
I think in general this is a bit of a nicer approach, but I still strongly dislike addition of AST into CIR. Particularly in this case, where all we're looking for is a handful of attributes about the function that we could store. The AST nodes make accepting IR from 'other' programs difficult/impossible, and IMO, we should avoid it if at all possible. https://github.com/llvm/llvm-project/pull/185134 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
