https://github.com/ojhunt commented:
Is it possible to rename isIntegralType here? maybe isIntegralStorage and have isIntegralType only be true in the "real" integer case? There are a bunch of uses of isIntegralType that I'm not sure are correct in the bytecode compiler that also seem at least a little suspect to me? and I think isIntegralType outside of the byte code doesn't appear to include fixed point. The fact that this PR is necessary seems to point to the current name resulting in it being used incorrectly. https://github.com/llvm/llvm-project/pull/185481 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
