================
@@ -1042,6 +1046,11 @@ void ApplyHeaderSearchOptions(HeaderSearch &HS,
 void normalizeModuleCachePath(FileManager &FileMgr, StringRef Path,
                               SmallVectorImpl<char> &NormalizedPath);
 
+std::string createSpecificModuleCachePath(FileManager &FileMgr,
----------------
jansvoboda11 wrote:

Yes, the call to `getSpecificModuleCachePath()` (now 
`createSpecificModuleCachePath()`) is in  
"clang/lib/Frontend/FrontendAction.cpp". There we don't have a `Preprocessor` 
or `HeaderSearch` set up yet, since we're only in the process of massaging 
`PreprocessorOptions`. This is why we need to compute it ourselves.

The second call is done from `HeaderSearch::initializeModuleCachePath()` which 
we call in "clang/lib/Frontend/CompilerInstance.cpp". I think this is indeed 
redundant with the first call, but I'm not 100% sure.

I personally don't mind this that much, but if we can find an elegant way to 
de-duplicate these calls, that'd be a good follow-up.

https://github.com/llvm/llvm-project/pull/185746
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to