llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Devajith (devajithvs)
<details>
<summary>Changes</summary>
getFullyQualifiedType() asserts "Unhandled type node" when the input QualType
is an AutoType.
This was exposed by clang-repl's value printer:
```
clang-repl> namespace N { struct D {}; }
clang-repl> auto x = N::D(); x // asserts
```
Strip AutoType early before the type-specific handling.
---
Full diff: https://github.com/llvm/llvm-project/pull/186105.diff
2 Files Affected:
- (modified) clang/lib/AST/QualTypeNames.cpp (+5)
- (modified) clang/test/Interpreter/pretty-print.cpp (+9)
``````````diff
diff --git a/clang/lib/AST/QualTypeNames.cpp b/clang/lib/AST/QualTypeNames.cpp
index 191841649a86f..9e3885e100c6b 100644
--- a/clang/lib/AST/QualTypeNames.cpp
+++ b/clang/lib/AST/QualTypeNames.cpp
@@ -369,6 +369,11 @@ NestedNameSpecifier createNestedNameSpecifier(const
ASTContext &Ctx,
/// versions of any template parameters.
QualType getFullyQualifiedType(QualType QT, const ASTContext &Ctx,
bool WithGlobalNsPrefix) {
+ // Use the underlying deduced type for AutoType
+ if (const auto *AT = dyn_cast<AutoType>(QT.getTypePtr()))
+ if (AT->isDeduced())
+ QT = AT->getDeducedType();
+
// In case of myType* we need to strip the pointer first, fully
// qualify and attach the pointer once again.
if (isa<PointerType>(QT.getTypePtr())) {
diff --git a/clang/test/Interpreter/pretty-print.cpp
b/clang/test/Interpreter/pretty-print.cpp
index bad71cdd48f0b..f0548358d65db 100644
--- a/clang/test/Interpreter/pretty-print.cpp
+++ b/clang/test/Interpreter/pretty-print.cpp
@@ -60,6 +60,15 @@ struct S5 { int foo() { return 42; }};
&S5::foo
// CHECK-NEXT: (int (S5::*)()) Function @0x{{[0-9a-f]+}}
+// Namespaced types deduced via auto
+namespace Outer { struct Foo {}; }
+auto x = Outer::Foo(); x
+// CHECK-NEXT: (Outer::Foo &) @0x{{[0-9a-f]+}}
+
+namespace Outer { template<class T> struct Bar {}; }
+auto y = Outer::Bar<int>(); y
+// CHECK-NEXT: (Outer::Bar<int> &) @0x{{[0-9a-f]+}}
+
// int i = 12;
// int &iref = i;
// iref
``````````
</details>
https://github.com/llvm/llvm-project/pull/186105
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
