https://github.com/timon-ul requested changes to this pull request.

Overall looks good, I hope my comments are not too nit picky. 

I noticed that in general this "trivial getter/setter" feature only works if 
they are defined and used in the same file. If you use a getter in a `cpp` file 
and it is defined in an included `hpp` it will not display that it is a trivial 
getter. This has nothing to do with your changes and was already like this 
before. @HighCommander4 is this intentional (due to limitations) or a bug? The 
only link I could find was [this](https://reviews.llvm.org/D77408?id=254819) 
and it only mentions the restrction of "Only if their definitions are visible 
and they have no other docs". Seems like it is supposed to work but doesn't? At 
least the feature feels a lot less useful if you can only use the getter in the 
same file if you want the info.

https://github.com/llvm/llvm-project/pull/182738
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to