=?utf-8?q?João?= Saffran <[email protected]>, =?utf-8?q?João?= Saffran <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
https://github.com/bogner requested changes to this pull request. This is not how we should do this - having the value we use to represent unbounded depend on the target is a recipe for user error and confusion. If we're changing to use 0 for unbounded instead of -1, we need to do this for all targets and update whatever documentation we have (ie, change the definition of the intrinsic such that the value 0 means unbounded). Otherwise, if we need this to stay as -1 for DirectX for some good reason, then we should instead take @s-perron's suggestion in https://github.com/llvm/llvm-project/pull/185551#issuecomment-4039363291 and handle converting this to a zero in the SPIR-V backend early (when we're handling the intrinsic itself). https://github.com/llvm/llvm-project/pull/186022 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
