llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) <details> <summary>Changes</summary> The one at the top of visitExpr doesn't make sense (we *just* started visiting the expression, how can there be leaked allocations?) and the one at the bottom is already handled via maybeDestroyLocals. --- Full diff: https://github.com/llvm/llvm-project/pull/186385.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+1-7) ``````````diff diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp index 27ae2eeb1b99c..13d6dcc92356d 100644 --- a/clang/lib/AST/ByteCode/Compiler.cpp +++ b/clang/lib/AST/ByteCode/Compiler.cpp @@ -5056,12 +5056,6 @@ template <class Emitter> bool Compiler<Emitter>::visitExpr(const Expr *E, bool DestroyToplevelScope) { LocalScope<Emitter> RootScope(this, ScopeKind::FullExpression); - // If we won't destroy the toplevel scope, check for memory leaks first. - if (!DestroyToplevelScope) { - if (!this->emitCheckAllocations(E)) - return false; - } - auto maybeDestroyLocals = [&]() -> bool { if (DestroyToplevelScope) return RootScope.destroyLocals() && this->emitCheckAllocations(E); @@ -5102,7 +5096,7 @@ bool Compiler<Emitter>::visitExpr(const Expr *E, bool DestroyToplevelScope) { return this->emitRetValue(E) && maybeDestroyLocals(); } - return maybeDestroyLocals() && this->emitCheckAllocations(E) && false; + return maybeDestroyLocals() && false; } template <class Emitter> `````````` </details> https://github.com/llvm/llvm-project/pull/186385 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
