llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (bharsesh) <details> <summary>Changes</summary> Add fortify warnings for bcopy and bzero as part of [llvm#<!-- -->142230](https://github.com/llvm/llvm-project/issues/142230) --- Full diff: https://github.com/llvm/llvm-project/pull/186522.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+9) - (modified) clang/test/Analysis/bstring.c (+2-1) - (modified) clang/test/Sema/warn-fortify-source.c (+12) ``````````diff diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 29add9d092e6b..dadb74a3ec99c 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -1405,6 +1405,8 @@ void Sema::checkFortifiedBuiltinMemoryFunction(FunctionDecl *FD, break; } + case Builtin::BIbzero: + case Builtin::BI__builtin_bzero: case Builtin::BImemcpy: case Builtin::BI__builtin_memcpy: case Builtin::BImemmove: @@ -1418,6 +1420,13 @@ void Sema::checkFortifiedBuiltinMemoryFunction(FunctionDecl *FD, DestinationSize = ComputeSizeArgument(0); break; } + case Builtin::BIbcopy: + case Builtin::BI__builtin_bcopy: { + DiagID = diag::warn_fortify_source_overflow; + SourceSize = ComputeExplicitObjectSizeArgument(TheCall->getNumArgs() - 1); + DestinationSize = ComputeSizeArgument(1); + break; + } case Builtin::BIsnprintf: case Builtin::BI__builtin_snprintf: case Builtin::BIvsnprintf: diff --git a/clang/test/Analysis/bstring.c b/clang/test/Analysis/bstring.c index f015e0b5d9fb7..01f85cecfbf43 100644 --- a/clang/test/Analysis/bstring.c +++ b/clang/test/Analysis/bstring.c @@ -508,7 +508,8 @@ void bcopy2 (void) { char src[] = {1, 2, 3, 4}; char dst[1]; - bcopy(src, dst, 4); // expected-warning{{overflow}} + bcopy(src, dst, 4); // expected-warning {{Memory copy function overflows the destination buffer}} + // expected-warning@-1 {{bcopy' will always overflow; destination buffer has size 1, but size argument is 4}} } void *malloc(size_t); diff --git a/clang/test/Sema/warn-fortify-source.c b/clang/test/Sema/warn-fortify-source.c index 750bd5361ade9..d0b519a516545 100644 --- a/clang/test/Sema/warn-fortify-source.c +++ b/clang/test/Sema/warn-fortify-source.c @@ -21,6 +21,8 @@ extern int sprintf(char *str, const char *format, ...); #else void *memcpy(void *dst, const void *src, size_t c); #endif +void bcopy(const void *src, void *dst, size_t n); +void bzero(void *dst, size_t n); #ifdef __cplusplus } @@ -104,6 +106,16 @@ void call_memset(void) { __builtin_memset(buf, 0xff, 11); // expected-warning {{'memset' will always overflow; destination buffer has size 10, but size argument is 11}} } +void call_bcopy_bzero(void) { + char src[20], dst[10]; + bcopy(src, dst, 20); // expected-warning {{'bcopy' will always overflow; destination buffer has size 10, but size argument is 20}} + bzero(dst, 11); // expected-warning {{'bzero' will always overflow; destination buffer has size 10, but size argument is 11}} + __builtin_bcopy(src, dst, 10); + __builtin_bcopy(src, dst, 20); // expected-warning {{'bcopy' will always overflow; destination buffer has size 10, but size argument is 20}} + __builtin_bzero(dst, 10); + __builtin_bzero(dst, 11); // expected-warning {{'bzero' will always overflow; destination buffer has size 10, but size argument is 11}} +} + void call_snprintf(double d, int n) { char buf[10]; __builtin_snprintf(buf, 10, "merp"); `````````` </details> https://github.com/llvm/llvm-project/pull/186522 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
