s-perron wrote:

> > Sorry I didn't pick up on this earlier. I should have looked closer.
> 
> Yah no worries :)
> 
> I made it into `AcquireRelease` now and locally that succeeds the test after 
> adding the `WorkGroupMemory` semantic, which is required for the `WorkGroup` 
> Scope. I added an assert for this.
> 
> In the future for `DeviceMemoryBarrier()`, should I also check that 
> `UniformMemory` and `ImageMemory` is set?

Yes that would be great thanks.

https://github.com/llvm/llvm-project/pull/185383
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to