vbvictor wrote: > I think they are unlikely to be affected by this commit since they already > banned Virtual inheritance (which is everything this PR is trying to > improve). For cases without virtual inheritance, the behavior is unchanged. > Also if they rely on the Fuchsia checks, finding virtual inheritance is > already covered by > [fuchsia-virtual-inheritance](https://clang.llvm.org/extra/clang-tidy/checks/fuchsia/virtual-inheritance.html).
Thank you for pointing out `fuchsia-virtual-inheritance`, yes it doesn't make sense to do any options here. Thank you for explanation! https://github.com/llvm/llvm-project/pull/186103 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
