unterumarmung wrote:

Thanks, especially to @HighCommander4, for the context. It seems there is real 
community need for proper support for non-self-contained files in clang 
tooling. The fact that this was implemented in a commercial downstream based on 
clang tooling makes that need even clearer.

I think some version of this feature should be implemented upstream. That would 
make the tooling more useful not only here, but also across LLVM-family 
projects with non-self-contained generated files, including LLVM, Clang, MLIR, 
Flang, and downstream projects built on top of LLVM tooling.

I agree it would be better to avoid having this only in clang-tidy. My original 
plan was to implement it there first and then follow up in include-cleaner / 
clangd, but I’m happy to change the order if starting from include-cleaner is 
the better direction.

It is a shame that include-cleaner does not currently have a maintainer. As I 
get more experience contributing to clang-based tooling, I’d be happy to help 
with reviews in this area as well.

Since this seems like a design question, I’d appreciate input from @vbvictor, 
@5chmidti, and @AaronBallman on the overall direction.

https://github.com/llvm/llvm-project/pull/180282
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to