https://github.com/abhijeetsharma200 updated https://github.com/llvm/llvm-project/pull/186634
>From c1ab56065998187504e674d4cf88e83b811e865c Mon Sep 17 00:00:00 2001 From: Abhijeet Sharma <[email protected]> Date: Sat, 14 Mar 2026 23:28:39 +0100 Subject: [PATCH 1/3] [clang] Fix 'implicitly deleted' diagnostic for explicitly deleted function template specializations, fixes #185693 --- clang/lib/Sema/SemaOverload.cpp | 4 +++- clang/test/SemaCXX/deleted-template-spec-diag.cpp | 12 ++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 clang/test/SemaCXX/deleted-template-spec-diag.cpp diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index 97018dbe81057..1ca340e8b72c7 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -12841,7 +12841,9 @@ static void NoteFunctionCandidate(Sema &S, OverloadCandidate *Cand, S.Diag(Fn->getLocation(), diag::note_ovl_candidate_deleted) << (unsigned)FnKindPair.first << (unsigned)FnKindPair.second << FnDesc - << (Fn->isDeleted() ? (Fn->isDeletedAsWritten() ? 1 : 2) : 0); + << (Fn->isDeleted() + ? (Fn->getCanonicalDecl()->isDeletedAsWritten() ? 1 : 2) + : 0); MaybeEmitInheritedConstructorNote(S, Cand->FoundDecl); return; } diff --git a/clang/test/SemaCXX/deleted-template-spec-diag.cpp b/clang/test/SemaCXX/deleted-template-spec-diag.cpp new file mode 100644 index 0000000000000..fe224b83c808d --- /dev/null +++ b/clang/test/SemaCXX/deleted-template-spec-diag.cpp @@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -std=c++11 -verify %s + +// https://github.com/llvm/llvm-project/issues/185693 +// Explicitly deleted function template specializations were incorrectly +// reported as "implicitly deleted" in overload resolution diagnostics. + +template <typename T> void fred(const T &x); +template <> void fred(const double &) = delete; // expected-note {{explicitly deleted}} + +int main() { + fred(8.0); // expected-error {{call to deleted function 'fred'}} +} >From 6136fc37b209931f83c5a7ddac927495c9493894 Mon Sep 17 00:00:00 2001 From: Abhijeet Sharma <[email protected]> Date: Sun, 15 Mar 2026 03:12:48 +0100 Subject: [PATCH 2/3] fixed failing tests --- clang/test/CXX/drs/cwg8xx.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/test/CXX/drs/cwg8xx.cpp b/clang/test/CXX/drs/cwg8xx.cpp index 7395f04c8e399..c76417fddbf25 100644 --- a/clang/test/CXX/drs/cwg8xx.cpp +++ b/clang/test/CXX/drs/cwg8xx.cpp @@ -23,10 +23,10 @@ template <> void f(int &&) = delete; // #cwg873-rvalue-ref void g(int i) { f(i); // calls f<int&>(int&) // since-cxx11-error@-1 {{call to deleted function 'f'}} - // since-cxx11-note@#cwg873-lvalue-ref {{candidate function [with T = int &] has been implicitly deleted}} + // since-cxx11-note@#cwg873-lvalue-ref {{candidate function [with T = int &] has been explicitly deleted}} f(0); // calls f<int>(int&&) // since-cxx11-error@-1 {{call to deleted function 'f'}} - // since-cxx11-note@#cwg873-rvalue-ref {{candidate function [with T = int] has been implicitly deleted}} + // since-cxx11-note@#cwg873-rvalue-ref {{candidate function [with T = int] has been explicitly deleted}} } #endif } // namespace cwg873 >From 2d1047f4915e237e35fa2ccc37041e6fdef56730 Mon Sep 17 00:00:00 2001 From: Abhijeet Sharma <[email protected]> Date: Sun, 15 Mar 2026 11:05:58 +0100 Subject: [PATCH 3/3] Added release notes --- clang/docs/ReleaseNotes.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index bacf2761ca816..c2d9e6d165e88 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -286,6 +286,9 @@ Improvements to Clang's diagnostics when parsing alias declarations involving a token-split ``>>`` sequence (for example, ``using A = X<int>>;``). (#GH184425) +- Fixed incorrect ``implicitly deleted`` diagnostic for explicitly deleted + candidate function. (#GH185693) + - The ``-Wloop-analysis`` warning has been extended to catch more cases of variable modification inside lambda expressions (#GH132038). _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
