================
@@ -42,8 +42,3 @@ A class that inherits from a pure virtual is allowed:
     virtual int foo() override { return 0; }
     virtual int bar() override { return 0; }
   };
-
-References
----------------
zeyi2 wrote:

I've removed the Fuchsia reference here, but I'd like to open a quick 
discussion to make sure this is exactly the direction we want to take.

IMHO having a "References" section for Fuchsia in a generic `misc` check isn't 
that ideal. However, while
the Fuchsia guidelines are still mentioned in the alias documentation 
(https://clang.llvm.org/extra/clang-tidy/checks/fuchsia/multiple-inheritance.html),
 that page has an automatic redirect to this rst file. From a user's 
perspective, they likely won't have enough time to actually read and click the 
guideline link before being redirected here.

I was wondering if we should follow the pattern used in 
[unused-return-value](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/unused-return-value.html)
 and replace the "References" section with a single note like this:

> :doc:`fuchsia-multiple-inheritance <../fuchsia/multiple-inheritance>` is an 
> alias of this check. See the features disallowed in Fuchsia at 
> https://fuchsia.dev/fuchsia-src/development/languages/c-cpp/cxx?hl=en

I feel this might be a better way to preserve the necessary context for Fuchsia 
users without making it the primary reference for a generic check.

WDYT?


https://github.com/llvm/llvm-project/pull/186657
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to