nextsilicon-itay-bookstein wrote: Right. So this basically mandates a change of approach in how the base PR propagates the include directories in `llvm_add_library` - it cannot do this with a plain `target_link_libraries`, it needs something like `$<COMPILE_ONLY:deptgt>` from https://discourse.cmake.org/t/add-only-library-headers-during-target-link-libraries/2973/17. Using that feature directly would necessitate CMake 3.27. There's a recent RFC to upgrade to 3.30, but that hasn't gone through yet: https://discourse.llvm.org/t/rfc-2026-upgrading-llvm-s-minimum-required-cmake-version/89829.
Anyway it seems like the right course of action is to revert and reevaluate, so I'll go ahead and do that. Thanks for the advice. https://github.com/llvm/llvm-project/pull/186672 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
