rturrado wrote: > Not a big fan of introducing a helper class (and a header + source file) > that's used exclusively in one function. I'm not even sure what #182790 is > talking about specifically.
Very fair, indeed. I had an initial implementation making use of just an extra `Expr *ArraySizeOptExpr`, but I didn't really like it because it was forcing me/the programmer to redefine that variable every time `ArraySize`, the `std::optional<Expr*>`, was being assigned to (which can be dangerous in case you forget to do it at some points). So I thought I'd better encapsulate that behaviour in a class. But that solution is indeed overkill as you have just said, not to mention that the API of that class turns out to be very ad-hoc... https://github.com/llvm/llvm-project/pull/186617 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
