gamesh411 wrote:

Cherry-pick of https://github.com/llvm/llvm-project/pull/113312 by @Szelethus, 
rebased onto current main. I've discussed with Husi about continuing this PR.

This patch moves the `isEnabled()` early-return guards from modeling functions 
to bug report emission sites in `CStringChecker`. Previously, disabling a 
sub-checker (e.g. `alpha.unix.cstring.OutOfBounds`) 
would skip modeling entirely, which prevented other sub-checkers from detecting 
issues that depended on that modeling. Now, modeling always runs; only the 
report construction is gated on whether the 
sub-checker is enabled.

Additionally, the redundant early-return in `checkAdditionOverflow` is removed 
— the overflow path is now unconditionally sunk (introduced in #152163 by 
@NagyDonat ), so I found the `OutOfBounds.isEnabled()` guard there was 
unnecessary.

According to the original plan, this patch a prerequisite for moving 
`alpha.unix.cstring.UninitializedRead` out of alpha.

https://github.com/llvm/llvm-project/pull/186802
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to