https://github.com/banach-space commented:
> @banach-space the work on vshr_* seemed to involve moving more code from the > incubator than I've seen in other PRs, so I'm a bit unsure if I'm correct > with this. Those changes made sense to me in order to cover all of vshr_* > variants but please let me know if I misunderstood something Yes, it just happened that this has involved code that has not been upstreamed yet, totally expected and thank you for including it! Though please try to extract the bare minimum that is is required (I identified one redundant argument). Btw, this PR seems to be adding 18 new tests to intrinsics.c (as expected based on https://arm-software.github.io/acle/neon_intrinsics/advsimd.html#vector-shift-right), but only 17 tests are deleted. Could you double check? Thank you for working on this! https://github.com/llvm/llvm-project/pull/186693 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
