boris marked 3 inline comments as done.
boris added a comment.
David, thanks for the review. Uploading the new revision (also rebased on HEAD).
================
Comment at: lib/Frontend/CompilerInvocation.cpp:1576
+ StringRef Str = Buf.get()->getBuffer();
+ for (size_t B(0), E(B); B < Str.size(); B = E + 1)
+ {
----------------
dblaikie wrote:
> Prefer copy init over direct init:
>
> for (size_t B = 0, E = 0;
>
> & probably != rather than < is more canonical/common in the LLVM codebase.
All done except the != change -- B can actually go one over size (see the npos
case in the loop body).
https://reviews.llvm.org/D37299
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
