[PATCH] D37454: [coroutines] desugar auto type of await_resume before checking whether it is void or bool

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: lib/Sema/SemaCoroutine.cpp:451
       if (RetType->isReferenceType() ||
           (AdjRetType != S.Context.BoolTy && AdjRetType != S.Context.VoidTy)) {
         S.Diag(AwaitSuspend->getCalleeDecl()->getLocation(),
----------------
Don't desugar the type; instead, use `AdjRetType->isBooleanType() || 
AdjRetType->isVoidType()` here. You can also delete the `getUnqualifiedType()` 
call above if you do this, and just use `RetType` here, since 
`->isBooleanType()` on `const bool` returns `true`.


https://reviews.llvm.org/D37454



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits