[clang] [clang] On Windows, silence warning in `WhitespaceManager` when build… (PR #187938)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-format

Author: Alexandre Ganea (aganea)

<details>
<summary>Changes</summary>

…ing with MSVC

This fixes:
```
[4544/7029] Building CXX object 
tools\clang\lib\Format\CMakeFiles\obj.clangFormat.dir\WhitespaceManager.cpp.obj
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveColons'::`2'::&lt;lambda_1&gt;
 &amp;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveShortCaseStatements'::`2'::&lt;lambda_1&gt;
 &amp;,3&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveDeclarations'::`2'::&lt;lambda_1&gt;
 &amp;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveAssignments'::`2'::&lt;lambda_1&gt;
 &amp;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveMacros'::`2'::&lt;lambda_1&gt;
 &amp;,1&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignChainedConditionals'::`7'::&lt;lambda_3&gt;
 &amp;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveColons'::`2'::&lt;lambda_1&gt;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()':
 not all control paths return a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveAssignments'::`2'::&lt;lambda_1&gt;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()':
 not all control paths return a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignChainedConditionals'::`5'::&lt;lambda_1&gt;
 &amp;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveDeclarations'::`2'::&lt;lambda_1&gt;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()':
 not all control paths return a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignChainedConditionals'::`5'::&lt;lambda_1&gt;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()':
 not all control paths return a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignConsecutiveShortCaseStatements'::`2'::&lt;lambda_1&gt;
 &amp;,2&gt;'::`4'::&lt;lambda_2&gt;::operator()': not all control paths return 
a value
C:\git\llvm-project\clang\lib\Format\WhitespaceManager.cpp(640) : warning 
C4715: 
'`clang::format::AlignTokens&lt;`clang::format::WhitespaceManager::alignChainedConditionals'::`7'::&lt;lambda_3&gt;,0&gt;'::`4'::&lt;lambda_2&gt;::operator()':
 not all control paths return a value
```

---
Full diff: https://github.com/llvm/llvm-project/pull/187938.diff


1 Files Affected:

- (modified) clang/lib/Format/WhitespaceManager.cpp (+3) 


``````````diff
diff --git a/clang/lib/Format/WhitespaceManager.cpp 
b/clang/lib/Format/WhitespaceManager.cpp
index d1cf8b2280534..f27f131e586d8 100644
--- a/clang/lib/Format/WhitespaceManager.cpp
+++ b/clang/lib/Format/WhitespaceManager.cpp
@@ -14,6 +14,7 @@
 #include "WhitespaceManager.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallVector.h"
+#include "llvm/Support/ErrorHandling.h"
 #include <algorithm>
 #include <limits>
 #include <optional>
@@ -636,6 +637,8 @@ static unsigned AlignTokens(const FormatStyle &Style, F 
&&Matches,
       case AlignStrategy::Macro:
       case AlignStrategy::Normal:
         return {true, false};
+      default:
+        llvm_unreachable("Unhandled AlignStrategy");
       }
     }();
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/187938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits