efriedma-quic wrote:

Needs regression test, probably in clang/test/Sema/ .  (See other files in the 
directory for examples.)

Adding new types to builtins requires threading it through a few different 
places: first 
https://github.com/llvm/llvm-project/blob/ca3d04561ba8686bb6dd094190a1f49f59ace652/clang/utils/TableGen/ClangBuiltinsEmitter.cpp#L341,
 then 
https://github.com/llvm/llvm-project/blob/ca3d04561ba8686bb6dd094190a1f49f59ace652/clang/lib/AST/ASTContext.cpp#L12611
 .  And then actually computing the type with something similar to what we do 
for FILE: 
https://github.com/llvm/llvm-project/blob/ca3d04561ba8686bb6dd094190a1f49f59ace652/clang/include/clang/AST/ASTContext.h#L2287
 .  Probably can leave it for a folllowup.

https://github.com/llvm/llvm-project/pull/187860
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to