================
@@ -237,6 +238,11 @@ class Target {
mca::InstrumentManager *(*)(const MCSubtargetInfo &STI,
const MCInstrInfo &MCII);
+ using MCLFIRewriterCtorTy =
+ MCLFIRewriter *(*)(MCStreamer & S,
----------------
zyedidia wrote:
I believe this should remain a raw pointer, consistent with other constructor
types. The `unique_ptr` should be created by the caller, allowing
`TargetRegistry.h` to avoid including many headers (like `MCLFIRewriter.h`)
which could affect compile times.
That formatting was strangely required by clang-format (see the earliest
revision of the bot's comment:
https://github.com/llvm/llvm-project/pull/172906#issuecomment-3672231791). As I
make the change outlined in the above comment, I'll see if I can have it accept
a better format.
https://github.com/llvm/llvm-project/pull/172906
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
