https://github.com/gysit commented:
mostly looks good from the LLVM dialect side. I would probably rename the flag to `isDebugInfoForProfiling` to match LLVM's naming and prior art. It would also be great to adapt the existing tests a bit to exercise the flag: - `llvm-project/mlir/test/Dialect/LLVMIR/debuginfo.mlir` exercises the byte code roundtrip - `llvm-project/mlir/test/Target/LLVMIR/Import/debug-info.ll` exercises the debug info import - `llvm-project/mlir/test/Target/LLVMIR/llvmir-debug.mlir` exercises the debug info export Likely it is sufficient to add the flag in existing tests. https://github.com/llvm/llvm-project/pull/188022 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
